-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change AuthenticatorTransport to be other than an enum
#1268
Comments
Just to be clear, right now the Web Authentication spec only allows values for AuthenticatorTransport that are in the level 1 spec. Permitting other values is a violation of WebIDL's definition of enumeration A fix for this would be to change
|
Also note, this is a breaking change, in that if updates aren't done in the right sequence, we'll have webcompat issues. |
It appears that Chromium has already made the breaking change, so we do have an active webcompat issue. Cite: https://security.googleblog.com/2019/08/making-authentication-even-easier-with_12.html |
* Type transport strings as DOMStrings. Currently transports are represented as an enum. However, WebIDL has strict enums. (I.e. an RP which sent an unrecognised transport would make the whole structure unparsable.) This means that every time we add a transport, we break all existing browsers. In order to address this, this change retypes transports as plain DOMStrings. The AuthenticatorTransport enum still exists, but now only as documentation and registry — not as a factor in type-checking. * Address Emil's comment Fixes #1268. * Address Jeff's comments.
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 --HG-- extra : moz-landing-system : lando
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 --HG-- extra : moz-landing-system : lando
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620
…r=bzbarsky,keeler a=RyanVM Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 --HG-- extra : rebase_source : 0d52b08eeaed266d322e03f4be8706157f130f12 extra : source : 069df0a1d93c091ca867423a7a8cd6bc36428201
…r=bzbarsky,keeler a=RyanVM Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620
…r=bzbarsky,keeler a=RyanVM Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 --HG-- extra : source : 069df0a1d93c091ca867423a7a8cd6bc36428201 extra : intermediate-source : 17b847ad15633a9419e8b98254000c4f413575db extra : histedit_source : d696281118eb94867015eda847aa051ee7a6c77f
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: cfdf258c11ae6136fdaa1e0786dba757fb284c48
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: 069df0a1d93c091ca867423a7a8cd6bc36428201
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: cfdf258c11ae6136fdaa1e0786dba757fb284c48
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: 069df0a1d93c091ca867423a7a8cd6bc36428201
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: cfdf258c11ae6136fdaa1e0786dba757fb284c48
…r=bzbarsky,keeler Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620 UltraBlame original commit: 069df0a1d93c091ca867423a7a8cd6bc36428201
…r=bzbarsky,keeler a=RyanVM Upstream: w3c/webauthn#1268 Differential Revision: https://phabricator.services.mozilla.com/D41620
we want to add values to
AuthenticatorTransport
without non-congnizant UAs throwing errors on values they are unaware of. change it to a sequence of strings? see also PR #1264The text was updated successfully, but these errors were encountered: