Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fixed the bikeshed errors #1715

Merged
merged 4 commits into from
Jan 24, 2025
+7 −7
Merged

Editorial: fixed the bikeshed errors #1715

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
765a27a
Editorial: fixed the bikeshed errors
yoshisatoyanagisawa Apr 30, 2024
cf76bf0
Addressed the comment.
yoshisatoyanagisawa May 8, 2024
f0e08c0
Reflected the review comments.
yoshisatoyanagisawa May 9, 2024
57d7612
Omit " and a user agent-defined message".
yoshisatoyanagisawa May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Omit " and a user agent-defined message". 
As suggested in the review, I have omitted the phrase.
@yoshisatoyanagisawa
yoshisatoyanagisawa committed May 9, 2024
commit 57d7612076fbcf90f8ebe92177754cddb16182b6
8 changes: 4 additions & 4 deletions docs/index.bs
View file
Original file line number Diff line number Diff line change
@@ -2139,7 +2139,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. Invoke [=Batch Cache Operations=] with |operations|. If this [=throws=] an exception, set |errorData| to the exception.
1. [=Queue a task=], on |cacheJobPromise|'s [=relevant settings object=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to perform the following substeps:
1. If |errorData| is null, resolve |cacheJobPromise| with undefined.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData|, in |realm|.
</section>

<section algorithm="cache-delete">
@@ -2168,7 +2168,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If |errorData| is null, then:
1. If |requestResponses| [=list/is not empty=], resolve |cacheJobPromise| with true.
1. Else, resolve |cacheJobPromise| with false.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.
1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData|, in |realm|.
1. Return |cacheJobPromise|.
</section>

@@ -2640,10 +2640,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
: Output
:: none

1. If |job|'s [=job/client=] is not null, [=queue a task=], on |job|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |job|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |job|'s [=job/client=]'s [=environment settings object/Realm=].
1. If |job|'s [=job/client=] is not null, [=queue a task=], on |job|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |job|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData|, in |job|'s [=job/client=]'s [=environment settings object/Realm=].
1. For each |equivalentJob| in |job|'s [=list of equivalent jobs=]:
1. If |equivalentJob|'s [=job/client=] is null, [=iteration/continue=].
1. [=Queue a task=], on |equivalentJob|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |equivalentJob|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |equivalentJob|'s [=job/client=]'s [=environment settings object/Realm=].
1. [=Queue a task=], on |equivalentJob|'s [=job/client=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to reject |equivalentJob|'s [=job/job promise=] with a [=exception/create|new=] [=exception=] with |errorData|, in |equivalentJob|'s [=job/client=]'s [=environment settings object/Realm=].
</section>

<section algorithm>