Editorial: fixed the bikeshed errors #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CL depends on whatwg/html#10308 to be merged because some symbols should be exported by the HTML specification.
|
@domenic @mkruisselbrink Will you review this? This fixes bikeshed errors I found during the ServiceWorker static routing API works. I tried to understand what the original bikeshed code tried to refer or tried to say, and revised them to fix the linking errors. Note that some phrases are depending on the HTML specification update, which I have already sent PR. Thank you, |
domenic
suggested changes
May 7, 2024
5 tasks
- link to navigation-hh instead of history-handling-behavior.
domenic
reviewed
May 8, 2024
As suggested in the review, I have omitted the phrase.
domenic
approved these changes
May 9, 2024
|
@domenic Thanks for the review. |
|
@mkruisselbrink Please let me know if there is anything to change. Thank you. |
|
Friendly ping? |
|
Since this is an editorial fix, let me merge this upon @domenic review. |
github-actions bot
added a commit
that referenced
this pull request
Jan 24, 2025
SHA: 522a17c Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Jan 24, 2025
SHA: 522a17c Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CL depends on whatwg/html#10308 to be merged because some symbols should be exported by the HTML specification.
Preview | Diff