Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken test #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove broken test #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea49c44
Mark broken endpoint as failing to have useful pass/fail
jellejurre Nov 19, 2024
652e305
Remove broken test
jellejurre Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/favorites.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ test(
}
);

test(
test.failing( //VRChat seems to have broken this endpoint ages ago?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of marking as failing, we should either remove it from tests & the spec or update the spec with the relevant changes to make it pass again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at it a bit and I think the endpoint is just broken by vrchat, nothing much we can do about it except for remove the endpoint from the spec.

They never use it, they only get favorites instead of single ones like this.

Do you want me to remove it from the spec as well then? I believe it has been broken for over a month and a half (see https://discord.com/channels/418093857394262020/418512124529344523/1293988342387703839)

testOperation,
"getFavorite",
{
Expand Down