Remove broken test #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariesclark
requested changes
Nov 25, 2024
tests/favorites.ts
Outdated
| @@ -54,7 +54,7 @@ test( | |||
| } | |||
| ); | |||
|
|
|||
| test( | |||
| test.failing( //VRChat seems to have broken this endpoint ages ago? | |||
There was a problem hiding this comment.
Instead of marking as failing, we should either remove it from tests & the spec or update the spec with the relevant changes to make it pass again.
There was a problem hiding this comment.
I looked at it a bit and I think the endpoint is just broken by vrchat, nothing much we can do about it except for remove the endpoint from the spec.
They never use it, they only get favorites instead of single ones like this.
Do you want me to remove it from the spec as well then? I believe it has been broken for over a month and a half (see https://discord.com/channels/418093857394262020/418512124529344523/1293988342387703839)
jellejurre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.