Skip to content

Conversation

tjohnson31415
Copy link
Collaborator

Description

Calls to input_batch.remove_request adjust the internal state of the batch and change the mapping from request ids to indices. If multiple removals are batched, they can cause the batch_update to have repeat indices, which leads to bugs. The change here forces input batch metadata updates to happen for each removal one-at-a-time; completely unbatching the batch_updates.

Related Issues

Fixes #508
See also #492 (comment)

Copy link

github-actions bot commented Oct 7, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@tjohnson31415
Copy link
Collaborator Author

bot:test

Copy link
Collaborator

@wallashss wallashss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@joerunde
Copy link
Collaborator

joerunde commented Oct 8, 2025

Thanks @tjohnson31415!

I assume we'll need to get a patch release out with this asap, right?

@tjohnson31415 tjohnson31415 merged commit 1c11f68 into main Oct 8, 2025
20 checks passed
@tjohnson31415 tjohnson31415 deleted the fix-logitsprocs branch October 8, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Requests are sometimes not respecting logitsprocs under load

3 participants