fix: unbatch removals of requests from input_batch #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calls to
input_batch.remove_request
adjust the internal state of the batch and change the mapping from request ids to indices. If multiple removals are batched, they can cause thebatch_update
to have repeat indices, which leads to bugs. The change here forces input batch metadata updates to happen for each removal one-at-a-time; completely unbatching the batch_updates.Related Issues
Fixes #508
See also #492 (comment)