Skip to content

🔥 rip out VLLM_SPYRE_TEST_BACKEND_LIST #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

🔥 rip out VLLM_SPYRE_TEST_BACKEND_LIST #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion _local_envs_for_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ export VLLM_SPYRE_DYNAMO_BACKEND=eager
# This makes debugging easy on local setup
export VLLM_ENABLE_V1_MULTIPROCESSING=0

export VLLM_SPYRE_TEST_BACKEND_LIST=eager
# We have to use `HF_HUB_OFFLINE=1` otherwise vllm might try to download a
# different version of the model using HF API which might not work locally
export HF_HUB_OFFLINE=1
8 changes: 3 additions & 5 deletions tests/spyre_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,12 @@ def get_spyre_model_dir_path() -> Path:
return Path(model_dir_path)


# get model backends from env or default to all and add pytest markers
# add pytest markers to supported different backends
def get_spyre_backend_list():
user_backend_list = os.environ.get("VLLM_SPYRE_TEST_BACKEND_LIST",
"eager,inductor,sendnn")
backend_list = ["eager", "inductor", "sendnn"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I could simplify this function more, but it does feel more readable this way 🤷


backends = []
for backend in user_backend_list.split(","):
backend = backend.strip()
for backend in backend_list:
marks = []
if backend == "eager":
marks = [pytest.mark.cpu]
Expand Down
21 changes: 0 additions & 21 deletions tests/utils/test_spyre_backend_list.py
View file
Open in desktop

This file was deleted.