Skip to content

Conversation

prashantgupta24
Copy link
Collaborator

Description

We anyway use markers for selecting the tests so this env var wasn't useful

Copy link

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@prashantgupta24 prashantgupta24 marked this pull request as draft September 25, 2025 17:28
We anyway use markers for selecting the tests so this env var wasn't useful

Signed-off-by: Prashant Gupta <[email protected]>
@prashantgupta24 prashantgupta24 marked this pull request as ready for review September 25, 2025 17:44
def get_spyre_backend_list():
user_backend_list = os.environ.get("VLLM_SPYRE_TEST_BACKEND_LIST",
"eager,inductor,sendnn")
backend_list = ["eager", "inductor", "sendnn"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I could simplify this function more, but it does feel more readable this way 🤷

Copy link
Collaborator

@joerunde joerunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️ !!!

@joerunde
Copy link
Collaborator

Low risk test-only changes, let's get it in

@joerunde joerunde merged commit 5b64d1b into main Sep 25, 2025
17 checks passed
@joerunde joerunde deleted the rip-test-var branch September 25, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants