Skip to content

Conversation

ckadner
Copy link
Collaborator

@ckadner ckadner commented Jun 2, 2025

No description provided.

Signed-off-by: Christian Kadner <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@ckadner ckadner requested a review from prashantgupta24 June 2, 2025 17:33
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) June 2, 2025 17:34
@prashantgupta24 prashantgupta24 disabled auto-merge June 2, 2025 17:34
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) June 2, 2025 17:34
@github-actions github-actions bot added the ready label Jun 2, 2025
@prashantgupta24 prashantgupta24 disabled auto-merge June 2, 2025 17:34
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) June 2, 2025 17:37
@prashantgupta24 prashantgupta24 disabled auto-merge June 2, 2025 17:37
@prashantgupta24 prashantgupta24 enabled auto-merge (squash) June 2, 2025 19:38
@prashantgupta24 prashantgupta24 disabled auto-merge June 2, 2025 19:38
@ckadner ckadner enabled auto-merge (squash) June 2, 2025 20:05
@yannicks1 yannicks1 self-requested a review June 3, 2025 10:54
ckadner added a commit that referenced this pull request Jun 3, 2025
**Problem**:

For with PRs that only change *.md files is that:
- if we skip tests, the required PR check for all the tests will never
report back to the PR and auto-merge won't be enabled, maintainers need
to manually merge ([example
PR](#194))
- if we don't skip tests, auto-merge will be enabled (if required tests
succeed), but it takes 10 minutes for PR checks to complete

There are no elegant solutions AFAIK.

**Options**:

- live with either of the situation described above
- don't skip workflow runs, instead use GHA marketplace action to skip
costly test steps based on changed files (this PR, creates a more
cluttered workflow file)
- have 2 workflow files for each PR check with the same name, one dummy
one that succeeds without running (harder to maintain)

If we don't merge this PR, or do similar changes, we could add more
"committers" by updating the branch protection rules bypass list to
enable forced merges on doc PRs

---------

Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner merged commit 903adc3 into vllm-project:main Jun 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants