Skip to content

Conversation

ckadner
Copy link
Collaborator

@ckadner ckadner commented Jun 2, 2025

WIP

Problem:

For with PRs that only change *.md files is that:

  • if we skip tests, the required PR check for all the tests will never report back to the PR and auto-merge won't be enabled, maintainers need to manually merge (example PR)
  • if we don't skip tests, auto-merge will be enabled (if required tests succeed), but it takes 10 minutes for PR checks to complete

There are no elegant solutions AFAIK.

Options:

  • live with either of the situation described above
  • don't skip workflow runs, instead use GHA marketplace action to skip costly test steps based on changed files (this PR, creates a more cluttered workflow file)
  • have 2 workflow files for each PR check with the same name, one dummy one that succeeds without running (harder to maintain)

If we don't merge this PR, or do similar changes, we could add more "committers" by updating the branch protection rules bypass list to enable forced merges on doc PRs

image

ckadner added 7 commits May 29, 2025 19:02
Signed-off-by: Christian Kadner <[email protected]>
Temporarily remove .github/workflows/test.yml file from
the list of changed source files to test skipping the test workflow

Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
@ckadner ckadner enabled auto-merge (squash) June 2, 2025 20:06
@github-actions github-actions bot added the ready label Jun 2, 2025
@vllm-project vllm-project deleted a comment from github-actions bot Jun 3, 2025
@ckadner ckadner merged commit 05fc3d9 into vllm-project:main Jun 3, 2025
21 checks passed
ckadner added a commit that referenced this pull request Jun 9, 2025
Currently, the tests workflow runs on every PR but skips actually
running the install and test steps when no source code was changed (PR
#193) in order to complete PR checks more quickly and preserve GHA
minutes, while allowing tests to be required PR check.

However, as witnessed in PR #213,
https://github.com/vllm-project/vllm-spyre/actions/runs/15474000691/job/43565048121,
tests don't run when only Python package versions are updated.

This PR changes that. Running full tests on `uv.lock` updates.

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants