-
Notifications
You must be signed in to change notification settings - Fork 26
[CI] Skip tests on doc changes #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kadner <[email protected]>
Temporarily remove .github/workflows/test.yml file from the list of changed source files to test skipping the test workflow Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
Signed-off-by: Christian Kadner <[email protected]>
sducouedic
reviewed
Jun 3, 2025
sducouedic
approved these changes
Jun 3, 2025
ckadner
added a commit
that referenced
this pull request
Jun 9, 2025
Currently, the tests workflow runs on every PR but skips actually running the install and test steps when no source code was changed (PR #193) in order to complete PR checks more quickly and preserve GHA minutes, while allowing tests to be required PR check. However, as witnessed in PR #213, https://github.com/vllm-project/vllm-spyre/actions/runs/15474000691/job/43565048121, tests don't run when only Python package versions are updated. This PR changes that. Running full tests on `uv.lock` updates. Signed-off-by: Christian Kadner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Problem:
For with PRs that only change *.md files is that:
There are no elegant solutions AFAIK.
Options:
If we don't merge this PR, or do similar changes, we could add more "committers" by updating the branch protection rules bypass list to enable forced merges on doc PRs