Skip to content

Conversation

ckadner
Copy link
Collaborator

@ckadner ckadner commented Jun 6, 2025

Currently, the tests workflow runs on every PR but skips actually running the install and test steps when no source code was changed (PR #193) in order to complete PR checks more quickly and preserve GHA minutes, while allowing tests to be required PR check.

However, as witnessed in PR #213, https://github.com/vllm-project/vllm-spyre/actions/runs/15474000691/job/43565048121, tests don't run when only Python package versions are updated.

This PR changes that. Running full tests on uv.lock updates.

@ckadner ckadner requested a review from joerunde as a code owner June 6, 2025 19:24
@ckadner ckadner requested a review from prashantgupta24 June 6, 2025 19:24
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

👋 Hi! Thank you for contributing to vLLM support on Spyre.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, first install the linting requirements, then run format.sh and commit the changes. This can be done with uv directly:

uv sync --frozen --group lint --active --inexact

Or this can be done with pip:

uv pip compile --group lint > requirements-lint.txt
pip install -r requirements-lint.txt
bash format.sh

Now you are good to go 🚀

@ckadner ckadner enabled auto-merge (squash) June 6, 2025 19:27
@github-actions github-actions bot added the ready label Jun 6, 2025
Copy link
Collaborator

@prashantgupta24 prashantgupta24 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do the 2 tests keep canceling?

tests/e2e/test_spyre_basic.py::test_output[v1-eager-warmup_shape0-prompts0-llama-194m] 
Error: The operation was canceled.

Copy link
Collaborator Author

@ckadner ckadner Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea!? Restarted it several times 🤷🏻‍♂️ Has nothing to do with these changes though.

@ckadner ckadner changed the title [CI] Don't skip tests when uv.lock is updated [CI] Don't skip tests when uv.lock is updated Jun 9, 2025
@joerunde joerunde disabled auto-merge June 9, 2025 17:34
@ckadner ckadner enabled auto-merge (squash) June 9, 2025 17:54
Copy link
Collaborator

@prashantgupta24 prashantgupta24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can merge once we fix the vllm main test though. Or I guess not.

@ckadner ckadner merged commit 2ae1108 into vllm-project:main Jun 9, 2025
59 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants