Skip to content

Fix filter for edge case & prefill bs > 1 #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix filter for edge case & prefill bs > 1 #634

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bbe7dd
Fix
adobrzyn Nov 26, 2025
8d8eccb
Update vllm_gaudi/extension/bucketing/common.py
adobrzyn Nov 26, 2025
75c9362
Merge branch 'main' into adobrzyn/fix_filter_for_prompt_bs_greater_1
adobrzyn Dec 1, 2025
6e7b674
Update common.py
adobrzyn Dec 1, 2025
b2e31f6
Merge branch 'main' into adobrzyn/fix_filter_for_prompt_bs_greater_1
adobrzyn Dec 1, 2025
13197da
Merge branch 'main' into adobrzyn/fix_filter_for_prompt_bs_greater_1
adobrzyn Dec 3, 2025
aa5a28d
Update common.py
adobrzyn Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm_gaudi/extension/bucketing/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def expand_to_neighbor_buckets(bs_idx, bs_range, ctx_idx, ctx_range, max_num_bat
# filter rules for buckets
# prompt
def not_over_max_model_len(bs, query, ctx):
smaller_than_limit = (query + ctx * block_size) <= max_model_len
smaller_than_limit = (query + ctx * block_size) <= max_model_len + block_size * max_num_prefill_seqs
if not smaller_than_limit:
omitted_buckets.add(
("condition: (query + ctx * block_size) <= max_model_len", "-> bs, query, ctx: ", bs, query, ctx))
Expand Down
Loading