Fix filter for edge case & prefill bs > 1 #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
adobrzyn
requested review from
afierka-intel,
iboiko-habana,
kamil-kaczor,
ksmusz,
kzawora-intel,
mgawarkiewicz-intel,
michalkuligowski,
vivekgoe and
xuechendi
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an edge case in the bucket filtering logic for prefill operations with batch sizes greater than 1. The change adjusts the maximum model length constraint to account for multiple prefill sequences by adding block_size * max_num_prefill_seqs to the limit.
- Updated bucket filter condition to accommodate larger batch sizes during prefill
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
jkaniecki
approved these changes
Nov 26, 2025
michalkuligowski
approved these changes
Nov 26, 2025
🚧 CI BlockedThe main CI workflow was not started for the following reason:
|
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
✅ CI PassedAll checks passed successfully against the following vllm commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.