[Bug] Accumulated bug fix on controller manager, mock app configuration, and gpu optimizer. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 10, 2024 11:44
Add test case for make url created from metricSource as expected: endpoint should include port, if not and port is specified, port will be append to endpoint.
zhangjyr
added
area/autoscaling
priority/critical-urgent
added 2 commits
December 11, 2024 15:27
zhangjyr
changed the title
Jeffwan
approved these changes
Dec 12, 2024
| spec: | ||
| scaleTargetRef: | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| name: simulator-llama2-7b-a40 | ||
| metricsSources: | ||
| - endpoint: aibrix-gpu-optimizer.aibrix-system.svc.cluster.local:8080 | ||
| - metricSourceType: domain |
There was a problem hiding this comment.
great to see new api is adopted.
| type RestMetricsFetcher struct{} | ||
| type RestMetricsFetcher struct { | ||
| // For unit test purpose only | ||
| test_url_setter func(string) |
There was a problem hiding this comment.
this is acceptable at this moment, we could consider RestMetricsFetcher interface later to better support testing
| @@ -101,7 +100,7 @@ async def send_request( | |||
| # "top_p": 1.0, | |||
| "max_tokens": output_len, | |||
| # "ignore_eos": True, | |||
| # "stream": stream, | |||
| # "stream": streaming | |||
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
…on, and gpu optimizer. (#522) * Bug fix * Fix configuration for domain podautoscaler Add test case for make url created from metricSource as expected: endpoint should include port, if not and port is specified, port will be append to endpoint. * Lint fix * Add license for new files. * Lint fix on added unit test. --------- Co-authored-by: Jingyuan Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixed:
A new unit test is added to ensure the controller manager handles the URL of domain metricsSource correctly.
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.