-
Notifications
You must be signed in to change notification settings - Fork 257
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Bug] Accumulated bug fix on controller manager, mock app configurati…
…on, and gpu optimizer. (#522) * Bug fix * Fix configuration for domain podautoscaler Add test case for make url created from metricSource as expected: endpoint should include port, if not and port is specified, port will be append to endpoint. * Lint fix * Add license for new files. * Lint fix on added unit test. --------- Co-authored-by: Jingyuan Zhang <[email protected]>
- Loading branch information
Showing
13 changed files
with
227 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
development/app/config/templates/podautoscaler/kustomization.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| resources: | ||
| - podautoscaler.yaml | ||
| - podautoscaler_kpa.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| /* | ||
| Copyright 2024 The Aibrix Team. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package metrics | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| autoscalingv1alpha1 "github.com/aibrix/aibrix/api/autoscaling/v1alpha1" | ||
| . "github.com/onsi/ginkgo" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func TestProxy(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "Metrics Suite") | ||
| } | ||
|
|
||
| // MetricFetcherRecorder records url used for fetching metrics. | ||
| type MetricFetcherRecorder struct { | ||
| RestMetricsFetcher | ||
|
|
||
| url string | ||
| } | ||
|
|
||
| func NewMetricFetcherRecorder() *MetricFetcherRecorder { | ||
| recorder := &MetricFetcherRecorder{} | ||
| recorder.RestMetricsFetcher.test_url_setter = func(url string) { | ||
| recorder.url = url | ||
| } | ||
| return recorder | ||
| } | ||
|
|
||
| func GetDomainMetricSource0() autoscalingv1alpha1.MetricSource { | ||
| return autoscalingv1alpha1.MetricSource{ | ||
| MetricSourceType: "domain", | ||
| ProtocolType: "http", | ||
| Endpoint: "example.com", | ||
| Path: "/metrics", | ||
| } | ||
| } | ||
|
|
||
| func GetDomainMetricSource1() autoscalingv1alpha1.MetricSource { | ||
| return autoscalingv1alpha1.MetricSource{ | ||
| MetricSourceType: "domain", | ||
| ProtocolType: "http", | ||
| Endpoint: "example.com:8080", | ||
| Path: "/metrics", | ||
| } | ||
| } | ||
|
|
||
| func GetDomainMetricSource2() autoscalingv1alpha1.MetricSource { | ||
| return autoscalingv1alpha1.MetricSource{ | ||
| MetricSourceType: "domain", | ||
| ProtocolType: "https", | ||
| Endpoint: "example.com", | ||
| Port: "8000", | ||
| Path: "metrics", | ||
| } | ||
| } | ||
|
|
||
| func GetDomainMetricSource3() autoscalingv1alpha1.MetricSource { | ||
| return autoscalingv1alpha1.MetricSource{ | ||
| MetricSourceType: "domain", | ||
| ProtocolType: "https", | ||
| Endpoint: "example.com:8080", | ||
| Port: "8000", | ||
| Path: "metrics", | ||
| } | ||
| } | ||
|
|
||
| var _ = Describe("KPAMetricsClient", func() { | ||
| It("should client fetch metrics from correct url", func() { | ||
| recorder := NewMetricFetcherRecorder() | ||
| client := NewKPAMetricsClient(recorder, 0, 0) | ||
|
|
||
| _, err := client.GetMetricFromSource(context.Background(), GetDomainMetricSource0()) | ||
| Expect(err).To(BeNil()) | ||
| Expect(recorder.url).To(Equal("http://example.com/metrics")) | ||
|
|
||
| _, err = client.GetMetricFromSource(context.Background(), GetDomainMetricSource1()) | ||
| Expect(err).To(BeNil()) | ||
| Expect(recorder.url).To(Equal("http://example.com:8080/metrics")) | ||
|
|
||
| _, err = client.GetMetricFromSource(context.Background(), GetDomainMetricSource2()) | ||
| Expect(err).To(BeNil()) | ||
| Expect(recorder.url).To(Equal("https://example.com:8000/metrics")) | ||
|
|
||
| _, err = client.GetMetricFromSource(context.Background(), GetDomainMetricSource3()) | ||
| Expect(err).To(BeNil()) | ||
| Expect(recorder.url).To(Equal("https://example.com:8080/metrics")) | ||
| }) | ||
|
|
||
| }) |
Oops, something went wrong.