Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Infer model name from model_uri and check AWS credential #250

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

brosoul
Copy link
Collaborator

@brosoul brosoul commented Sep 27, 2024

Pull Request Description

  1. Infer model name from model_uri and update related docs, address DOWNLOADER_MODEL_NAME blocks the runtime to download other models #212
  2. Check the existence of AWS credential, address aibrix throw AttributeError if the credentials is missed #208

Related Issues

Resolves: #212, #208

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@brosoul brosoul changed the title [Misc] Infer model name from model_uri [Misc] Infer model name from model_uri and check AWS credential Sep 27, 2024
@brosoul brosoul requested a review from Jeffwan September 27, 2024 08:51
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, --model-name is still a little bit confused, --model-folder-name makes more sense for a downloader library. this is not feature/bug related and we can improve it later

@Jeffwan Jeffwan merged commit b664587 into main Sep 27, 2024
10 checks passed
@Jeffwan Jeffwan deleted the linhui/refact-model-dir branch September 27, 2024 13:53
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* refact: remove env DOWNLOADER_MODEL_NAME

* style

* test: fix test case

* docs: update doc about remove DOWNLOADER_MODEL_NAME

* misc: add ak sk check in s3 download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOWNLOADER_MODEL_NAME blocks the runtime to download other models
2 participants