Skip to content

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 14, 2026

What?

Make make_chunks a cached function to allow it to be cached even when the module graph changes (assuming that chunk group's chunk items are not affected by the change)

Copy link
Member Author

sokra commented Jan 14, 2026

@nextjs-bot
Copy link
Collaborator

Allow CI Workflow Run

  • approve CI run for commit: b59bb44

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@nextjs-bot
Copy link
Collaborator

Allow CI Workflow Run

  • approve CI run for commit: b59bb44

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁█▁▁▁
Cold (Ready in log) 437ms 438ms ▂█▂▂▂
Cold (First Request) 1.222s 1.164s ▄█▄▄▄
Warm (Listen) 456ms 457ms ▁█▁▁▁
Warm (Ready in log) 441ms 441ms ▁█▁▁▁
Warm (First Request) 339ms 340ms ▁█▂▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 457ms 456ms ▁█▁▁▁
Cold (Ready in log) 439ms 439ms ▇▁▇█▆
Cold (First Request) 1.835s 1.834s █▂▇▇▇
Warm (Listen) 456ms 456ms █▅▁▅▅
Warm (Ready in log) 440ms 440ms ▇▁▇█▇
Warm (First Request) 1.838s 1.860s █▁▇█▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.255s 4.314s ▁█▁▁▁
Cached Build 4.334s 4.350s ▁█▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.013s 14.051s ▅█▁▂▅
Cached Build 14.116s 14.136s ██▂▃▇
node_modules Size 458 MB 458 MB ▁▁███
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -81 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 790 B 785 B
Total 790 B 785 B ✅ -5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 450 B
Total 449 B 450 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 38.9 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -10 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B
_error-HASH.js gzip 182 B 182 B
css-HASH.js gzip 336 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 352 B 349 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 259 B 258 B
link-HASH.js gzip 2.5 kB 2.51 kB
routerDirect..HASH.js gzip 319 B 317 B
script-HASH.js gzip 385 B 387 B
withRouter-HASH.js gzip 316 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 242 kB 237 kB 🟢 4.86 kB (-2%)
Total 366 kB 362 kB ✅ -4.85 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 654 B 653 B
middleware-r..fest.js gzip 155 B 156 B
middleware.js gzip 33.1 kB 33.3 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.8 kB 34.9 kB ⚠️ +157 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B
Total 738 B 738 B
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.66 MB 🔴 +7.24 kB (+0%)
index.pack gzip 99.6 kB 99.1 kB
index.pack.old gzip 98.4 kB 99 kB
Total 3.86 MB 3.86 MB ⚠️ +7.19 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB
app-page-exp..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 304 kB 304 kB
app-page-tur..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 300 kB 300 kB
app-page-tur..prod.js gzip 156 kB 156 kB
app-page.run...dev.js gzip 300 kB 300 kB
app-page.run..prod.js gzip 156 kB 156 kB
app-route-ex...dev.js gzip 68.8 kB 68.8 kB
app-route-ex..prod.js gzip 47.6 kB 47.6 kB
app-route-tu...dev.js gzip 68.8 kB 68.8 kB
app-route-tu..prod.js gzip 47.6 kB 47.6 kB
app-route-tu...dev.js gzip 68.4 kB 68.4 kB
app-route-tu..prod.js gzip 47.4 kB 47.4 kB
app-route.ru...dev.js gzip 68.4 kB 68.4 kB
app-route.ru..prod.js gzip 47.3 kB 47.3 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB
pages-turbo....dev.js gzip 50.8 kB 50.8 kB
pages-turbo...prod.js gzip 38.2 kB 38.2 kB
pages.runtim...dev.js gzip 50.7 kB 50.7 kB
pages.runtim..prod.js gzip 38.2 kB 38.2 kB
server.runti..prod.js gzip 62.2 kB 62.2 kB
Total 2.69 MB 2.69 MB ✅ -2 B

@sokra sokra marked this pull request as ready for review January 15, 2026 07:47
@sokra sokra requested a review from mischnic January 15, 2026 07:59
@sokra sokra force-pushed the sokra/make-chunks-cache branch from b59bb44 to 6c030b9 Compare January 15, 2026 07:59
@sokra sokra force-pushed the sokra/merged-modules-selective branch 2 times, most recently from 4b38276 to f655453 Compare January 15, 2026 10:51
@sokra sokra force-pushed the sokra/make-chunks-cache branch 2 times, most recently from 7eb2e99 to e674a8b Compare January 15, 2026 10:55
@sokra sokra force-pushed the sokra/merged-modules-selective branch from f655453 to 5d26752 Compare January 15, 2026 10:55
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing sokra/make-chunks-cache (2e07870) with canary (a8b0f9d)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sokra sokra force-pushed the sokra/make-chunks-cache branch from e674a8b to d22f730 Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/merged-modules-selective branch 2 times, most recently from 6a2c423 to 417f80f Compare January 15, 2026 19:23
@sokra sokra force-pushed the sokra/make-chunks-cache branch from d22f730 to 46ab09d Compare January 15, 2026 19:24
@sokra sokra force-pushed the sokra/merged-modules-selective branch 2 times, most recently from ba514f5 to 733a56f Compare January 16, 2026 05:48
@sokra sokra force-pushed the sokra/make-chunks-cache branch 2 times, most recently from cc74267 to 6d683eb Compare January 16, 2026 05:49
@sokra sokra force-pushed the sokra/merged-modules-selective branch from 733a56f to 79c0c1e Compare January 16, 2026 08:38
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 6d683eb to 70ab818 Compare January 16, 2026 08:38
@sokra sokra force-pushed the sokra/merged-modules-selective branch from 79c0c1e to aa766fa Compare January 16, 2026 09:03
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 70ab818 to 5669332 Compare January 16, 2026 09:04
@sokra sokra force-pushed the sokra/merged-modules-selective branch from aa766fa to 95d32c3 Compare January 16, 2026 09:44
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 5669332 to dacd83f Compare January 16, 2026 09:45
@sokra sokra force-pushed the sokra/merged-modules-selective branch from 95d32c3 to 2ea978f Compare January 16, 2026 12:09
@sokra sokra force-pushed the sokra/make-chunks-cache branch from dacd83f to 22f8fbd Compare January 16, 2026 12:10
@sokra sokra force-pushed the sokra/merged-modules-selective branch from 2ea978f to e36980f Compare January 16, 2026 12:28
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 22f8fbd to 549c9bd Compare January 16, 2026 12:28
@sokra sokra force-pushed the sokra/merged-modules-selective branch from e36980f to f693acb Compare January 16, 2026 13:18
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 549c9bd to 88a56a6 Compare January 16, 2026 13:19
@sokra sokra force-pushed the sokra/merged-modules-selective branch 2 times, most recently from 5371a4a to 270b86a Compare January 16, 2026 14:34
@sokra sokra force-pushed the sokra/make-chunks-cache branch from 88a56a6 to be9ef9f Compare January 16, 2026 14:35
@sokra sokra changed the base branch from sokra/merged-modules-selective to graphite-base/88561 January 16, 2026 15:05
@sokra sokra force-pushed the sokra/make-chunks-cache branch from be9ef9f to d99eb30 Compare January 16, 2026 15:06
@sokra sokra force-pushed the graphite-base/88561 branch from 270b86a to a8b0f9d Compare January 16, 2026 15:06
@graphite-app graphite-app bot changed the base branch from graphite-base/88561 to canary January 16, 2026 15:07
make make_chunks a cached function
@sokra sokra force-pushed the sokra/make-chunks-cache branch from d99eb30 to 2e07870 Compare January 16, 2026 15:07
@sokra sokra merged commit c38e57f into canary Jan 16, 2026
294 of 296 checks passed
Copy link
Member Author

sokra commented Jan 16, 2026

Merge activity

@sokra sokra deleted the sokra/make-chunks-cache branch January 16, 2026 15:45
wyattjoh pushed a commit that referenced this pull request Jan 16, 2026
### What?

Make make_chunks a cached function to allow it to be cached even when the module graph changes (assuming that chunk group's chunk items are not affected by the change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants