Turbopack: snapshot the ModuleGraph to avoid (eventual) inconsistent graphs #88340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextjs-bot
added
created-by: Turbopack team
This was referenced Jan 9, 2026
Member
Author
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
sokra
changed the title
sokra
force-pushed
the
sokra/parallel-backend
branch
from
9b8b94f to
e70e940
Compare
sokra
force-pushed
the
sokra/module-graph-consistency
branch
from
52d9dd0 to
965d41d
Compare
This was referenced Jan 12, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Comment on lines
+967
to
+977
| let binding_usage_info = remove_unused_imports.then(|| { | ||
| compute_binding_usage_info( | ||
| ModuleGraph::from_graphs(graphs.clone()), | ||
| should_read_binding_usage, | ||
| ) | ||
| }); | ||
|
|
||
| let full = if let Some(binding_usage_info) = binding_usage_info { | ||
| ModuleGraph::from_graphs_without_unused_references(graphs, binding_usage_info) | ||
| } else { | ||
| full_with_unused_references | ||
| ModuleGraph::from_graphs(graphs) |
Contributor
There was a problem hiding this comment.
Suggested change
| let binding_usage_info = remove_unused_imports.then(|| { | |
| compute_binding_usage_info( | |
| ModuleGraph::from_graphs(graphs.clone()), | |
| should_read_binding_usage, | |
| ) | |
| }); | |
| let full = if let Some(binding_usage_info) = binding_usage_info { | |
| ModuleGraph::from_graphs_without_unused_references(graphs, binding_usage_info) | |
| } else { | |
| full_with_unused_references | |
| ModuleGraph::from_graphs(graphs) | |
| let (full, binding_usage_info) = if remove_unused_imports { | |
| let full_with_unused_references = ModuleGraph::from_graphs(graphs.clone()); | |
| let binding_usage_info = compute_binding_usage_info( | |
| full_with_unused_references, | |
| should_read_binding_usage, | |
| ); | |
| ( | |
| ModuleGraph::from_graphs_without_unused_references(graphs, binding_usage_info), | |
| Some(binding_usage_info), | |
| ) | |
| } else { | |
| (ModuleGraph::from_graphs(graphs), None) |
Type mismatch in binding_usage_info assignment - closure returns Future instead of OperationVc
CodSpeed Performance ReportMerging this PR will improve performance by 3.6%Comparing Summary
Performance Changes
Footnotes
|
Collaborator
Failing test suitesCommit: 965d41d | About building and testing Next.js
Expand output● Errors on invalid custom routes › development mode › should error during next build for invalid headers |
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **430 kB** → **430 kB** ✅ -29 B82 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
mischnic
reviewed
Jan 12, 2026
Comment on lines
518
to
-524
| impl ClientReferencesGraph { | ||
| #[turbo_tasks::function] | ||
| pub async fn new_with_entries( | ||
| graph: SingleModuleGraphWithBindingUsage, | ||
| graph: ResolvedVc<ModuleGraph>, | ||
| is_single_page: bool, | ||
| ) -> Result<Vc<Self>> { | ||
| let mapped = map_client_references(*graph.graph); |
Contributor
There was a problem hiding this comment.
Previously, the types ensured/made it obvious that this should be one of the individual stacked graphs.
But not anymore, even though it's still the individual graph, as far as I can tell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor ModuleGraph to be a strongly consistent snapshot of the module graph. This should avoid eventually consistency problems where different versions of single module graphs do not fit together.