Skip to content

fix: fix default value of optimizeBundle setting #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2025
Merged

fix: fix default value of optimizeBundle setting #4473

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a188a13
fix: fix default value of optimizeBundle setting
mcollovati Aug 8, 2025
c70e281
Merge branch 'v24' into fix/optimizeBundle-default-value
mcollovati Oct 20, 2025
77b02e3
apply review suggestions
mcollovati Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion articles/flow/configuration/properties.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ Bundle parameter controls parts of frontend bundle creation.
|`devmode.optimizeBundle`
|`vaadin.devmode.optimizeBundle`
|Optimizes frontend resource bundles. All frontend resources in the classpath are included by default in the generated bundle in development mode. When set to `true`, the frontend build creates an optimized bundle by including only frontend resources that are used from the application entry points. It uses bytecode scanning, which increases application start-up time. Set to `false` to skip the optimization in production mode.
|`false`
|`true`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem correct to me.
devmode.optimizeBundle is false by default (dev mode) whereas optimizeBundle build parameter is true.
I'd rather add optimizeBundle with true default into the Vaadin Plugin Properties section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Let me fix the PR as suggested

|Build

|`devmode.output.pattern.timeout`
Expand Down
Loading