fix: fix default value of optimizeBundle setting #4473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI Language ReviewIn the "vaadin-plugin-properties" section, under `optimizeBundle`, the default value for this property has been updated from an implicit `false` in the old version to an explicit `true` in the new version. Ensure users are aware of this change, as it may affect the build output if they rely on the default behavior.
Additionally, consider adding a clarifying note in the description to inform users about the potential increase in build time when optimizing bundles due to bytecode scanning. This information was present in the `devmode.optimizeBundle` property description in the main "Properties Defined" table, but it should also be included here to maintain comprehensive and consistent documentation.
In general, ensure consistency between the main properties table and the Vaadin Plugin Properties table for shared settings. |
mshabarov
requested changes
Aug 15, 2025
| |`vaadin.devmode.optimizeBundle` | ||
| |Optimizes frontend resource bundles. All frontend resources in the classpath are included by default in the generated bundle in development mode. When set to `true`, the frontend build creates an optimized bundle by including only frontend resources that are used from the application entry points. It uses bytecode scanning, which increases application start-up time. Set to `false` to skip the optimization in production mode. | ||
| |`false` | ||
| |`true` |
There was a problem hiding this comment.
This doesn't seem correct to me.
devmode.optimizeBundle is false by default (dev mode) whereas optimizeBundle build parameter is true.
I'd rather add optimizeBundle with true default into the Vaadin Plugin Properties section.
There was a problem hiding this comment.
Good point! Let me fix the PR as suggested
mshabarov
approved these changes
Oct 21, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
* fix: fix default value of optimizeBundle setting * apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.