Skip to content

Load balancing backoffice: Add missing id to distributed jobs when updating #20642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2025
+8 −1
Merged

Load balancing backoffice: Add missing id to distributed jobs when updating #20642

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2624695
Add ID when updating background job
nikolajlauridsen Oct 24, 2025
9d3e68e
Reduce default period to 5 seconds
nikolajlauridsen Oct 24, 2025
1e39525
Apply suggestions from code review
nikolajlauridsen Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Umbraco.Core/Configuration/Models/DistributedJobSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace Umbraco.Cms.Core.Configuration.Models;
[UmbracoOptions(Constants.Configuration.ConfigDistributedJobs)]
public class DistributedJobSettings
{
internal const string StaticPeriod = "00:00:10";
internal const string StaticPeriod = "00:00:05";
internal const string StaticDelay = "00:01:00";

/// <summary>
Expand Down
5 changes: 5 additions & 0 deletions src/Umbraco.Infrastructure/Models/DistributedBackgroundJobModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
/// </summary>
public class DistributedBackgroundJobModel
{
/// <summary>
/// The id of the job.
/// </summary>
public int? Id { get; set; }

/// <summary>
/// Name of job.
/// </summary>
Expand Down
2 changes: 2 additions & 0 deletions src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DistributedJobRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ public void Delete(DistributedBackgroundJobModel distributedBackgroundJob)
private DistributedJobDto MapToDto(DistributedBackgroundJobModel model) =>
new()
{
Id = model.Id ?? 0,
Name = model.Name,
Period = model.Period.Ticks,
LastRun = model.LastRun,
Expand All @@ -100,6 +101,7 @@ private DistributedJobDto MapToDto(DistributedBackgroundJobModel model) =>
private DistributedBackgroundJobModel MapFromDto(DistributedJobDto jobDto) =>
new()
{
Id = jobDto.Id,
Name = jobDto.Name,
Period = TimeSpan.FromTicks(jobDto.Period),
LastRun = jobDto.LastRun,
Expand Down
Loading