Load balancing backoffice: Add missing id to distributed jobs when updating #20642
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing ID mapping to the distributed background job model to support proper updates during load-balanced backoffice operations. The primary issue was that the ID field was not being mapped between the DTO and domain model, which would prevent existing jobs from being properly updated in the database.
Key Changes:
- Added nullable
Idproperty toDistributedBackgroundJobModelto track job identity - Updated mapping methods to include ID field in both directions (model ↔ DTO)
- Reduced distributed job execution period from 10 to 5 seconds
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Infrastructure/Models/DistributedBackgroundJobModel.cs | Added nullable Id property with XML documentation to track job identity |
| src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DistributedJobRepository.cs | Updated MapToDto and MapFromDto methods to include ID field mapping |
| src/Umbraco.Core/Configuration/Models/DistributedJobSettings.cs | Changed StaticPeriod constant from 10 to 5 seconds |
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DistributedJobRepository.cs
Outdated
Show resolved
Hide resolved
AndyButland
approved these changes
Oct 24, 2025
src/Umbraco.Infrastructure/Models/DistributedBackgroundJobModel.cs
Outdated
Show resolved
Hide resolved
src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DistributedJobRepository.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Butland <[email protected]>
nikolajlauridsen
added
the
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ID was missing when updating the distributed jobs status, meaning they would never actually update, and we kept running the same job over and over again.
If you now run and wait for the job to run (1 minute), you should see the database start updating.
I also reduced the period between job checks to 5 seconds, because the webhook jobs run every 10 seconds, so it seemed like a good idea to check more frequently than every 10 seconds