Skip to content

Section URL Retention: Ability to prevent it for a section #20637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
+4 −2
Merged

Section URL Retention: Ability to prevent it for a section #20637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b2d693
Have to control of the state store navigation for custom sections or …
Oct 24, 2025
2c32d68
revert wording
nielslyngsoe Oct 29, 2025
bba555f
move logic and update comment
nielslyngsoe Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...mbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-header-sections.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@

const clickedSectionAlias = manifest.alias;

// If the clicked section is the same as the current section, we just load the original section path to load the section root
if (this._currentSectionAlias === clickedSectionAlias) {
// If preventUrlRetention is set to true then go to the section root.
// Or if the clicked section is the current active one, then navigate to the section root
if (manifest?.meta.preventUrlRetention === true || this._currentSectionAlias === clickedSectionAlias) {

Check warning on line 88 in src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-header-sections.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Method 

UmbBackofficeHeaderSectionsElement.onSectionClick has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
const sectionPath = this.#getSectionPath(manifest);
history.pushState(null, '', sectionPath);
return;
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/packages/core/section/extensions/section.extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ export interface ManifestSection
export interface MetaSection {
label: string;
pathname: string;
preventUrlRetention?: boolean;
}
Loading