Skip to content

Conversation

@rammi987
Copy link
Contributor

…overrides

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #20636

Description

ass suggest in the issuse add some control to control if the custom sections wants the navigation store state, or by overrides on the manifest.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Hi there @rammi987, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nielslyngsoe nielslyngsoe merged commit 7af67d2 into umbraco:main Oct 29, 2025
26 of 27 checks passed
@nielslyngsoe nielslyngsoe changed the title Have to control of the state store navigation for custom sections or … Section URL Retention: Ability to prevent it for a section Oct 29, 2025
@nielslyngsoe
Copy link
Member

Hi @rammi987, Thanks for your PR. I took the freedom to adjust it slightly, fix a minor mistake, and revert the meaning of the property.

So notice how it's now called preventUrlRetention, and for your case you should set it to `true´, and then please for you and anyone reading this, do notice it is not recommended to bring an inconsistent UX, so please use this very carefully. This may hint that your Section should not have been a Section in the first place. But I accept the perspective, and since it could be seen as a UX regression, I have included this in the upcoming v.16.4 and 17.0(despite being in RC period).

Good luck with the project :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

16.3 feature state kept when navigating between sections to aggrasive

3 participants