Skip to content

Trashbin: introduce a empty trash icon #20629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: v17/dev
Choose a base branch
from
+20 −8
Open

Trashbin: introduce a empty trash icon #20629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
032da98
add empty trash icon and use it for empty trash-bin and delete from t…
nielslyngsoe Oct 23, 2025
f45b106
package lock
nielslyngsoe Oct 23, 2025
87609d6
Merge branch 'v17/dev' into v17/feature/trash-empty-icon
nielslyngsoe Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Umbraco.Web.UI.Client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-dictionary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2894,6 +2894,11 @@
"file": "icon-molecular.svg",
"legacy": true
},
{
"name": "icon-trash-empty",
"file": "icon-trash-empty.svg",
"internal": true
},
{
"name": "icon-umbraco",
"file": "icon-umbraco.svg"
Expand Down
3 changes: 3 additions & 0 deletions src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2209,6 +2209,9 @@ name: "icon-molecular",
hidden: true,
path: () => import("./icons/icon-molecular.js"),
},{
name: "icon-trash-empty",
path: () => import("./icons/icon-trash-empty.js"),
},{
name: "icon-umbraco",
path: () => import("./icons/icon-umbraco.js"),
},{
Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-company.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export default `<svg xmlns="http://www.w3.org/2000/svg" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.75" class="lucide lucide-building-2" viewBox="0 0 24 24"><path d="M6 22V4a2 2 0 0 1 2-2h8a2 2 0 0 1 2 2v18ZM6 12H4a2 2 0 0 0-2 2v6a2 2 0 0 0 2 2h2M18 9h2a2 2 0 0 1 2 2v9a2 2 0 0 1-2 2h-2M10 6h4M10 10h4M10 14h4M10 18h4"/></svg>`;
export default `<svg xmlns="http://www.w3.org/2000/svg" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.75" class="lucide lucide-building-2" viewBox="0 0 24 24"><path d="M10 12h4M10 8h4M14 21v-3a2 2 0 0 0-4 0v3"/><path d="M6 10H4a2 2 0 0 0-2 2v7a2 2 0 0 0 2 2h16a2 2 0 0 0 2-2V9a2 2 0 0 0-2-2h-2"/><path d="M6 21V5a2 2 0 0 1 2-2h8a2 2 0 0 1 2 2v16"/></svg>`;
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-trash-empty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default `<svg xmlns="http://www.w3.org/2000/svg" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round" stroke-width="1.75" class="lucide lucide-trash-2" viewBox="0 0 24 24"><path d="m14.6 11.4-5.2 5.2m0-5.2 5.2 5.2M19 6v14c0 1.1-.9 2-2 2H7c-1.1 0-2-.9-2-2V6M3 6h18M8 6V4c0-1.1.9-2 2-2h4c1.1 0 2 .9 2 2v2" class="cls-1"/></svg>`;
1 change: 1 addition & 0 deletions ...Umbraco.Web.UI.Client/src/packages/core/icon-registry/svgs/icon-trash-empty.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/Umbraco.Web.UI.Client/src/packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"@hey-api/openapi-ts": "0.85.0"
},
"devDependencies": {
"lucide-static": "^0.544.0",
"lucide-static": "^0.546.0",
"simple-icons": "^15.16.1",
"svgo": "^4.0.0"
}
}
}
2 changes: 1 addition & 1 deletion ...ackages/core/recycle-bin/entity-action/empty-recycle-bin/empty-recycle-bin.action.kind.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const manifest: UmbExtensionManifestKind = {
weight: 100,
forEntityTypes: [],
meta: {
icon: 'icon-trash',
icon: 'icon-trash-empty',
label: 'Empty Recycle Bin',
additionalOptions: true,
},
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const entityActions: Array<UmbExtensionManifest> = [
name: 'Delete Document Entity Action',
forEntityTypes: [UMB_DOCUMENT_ENTITY_TYPE],
meta: {
icon: 'icon-trash-empty',
itemRepositoryAlias: UMB_DOCUMENT_ITEM_REPOSITORY_ALIAS,
detailRepositoryAlias: UMB_DOCUMENT_DETAIL_REPOSITORY_ALIAS,
referenceRepositoryAlias: UMB_DOCUMENT_REFERENCE_REPOSITORY_ALIAS,
Expand Down
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export const manifests: Array<UmbExtensionManifest> = [
kind: 'deleteWithRelation',
forEntityTypes: [UMB_MEDIA_ENTITY_TYPE],
meta: {
icon: 'icon-trash-empty',
itemRepositoryAlias: UMB_MEDIA_ITEM_REPOSITORY_ALIAS,
detailRepositoryAlias: UMB_MEDIA_DETAIL_REPOSITORY_ALIAS,
referenceRepositoryAlias: UMB_MEDIA_REFERENCE_REPOSITORY_ALIAS,
Expand Down
Loading