Trashbin: introduce a empty trash icon #20629
Open
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new icon-trash-empty icon to represent delete actions in the trash bin/recycle bin. The icon is sourced from the updated lucide-static library and applied to delete entity actions across documents and media.
- Adds new
icon-trash-emptyicon from lucide-static - Updates delete actions for documents and media to use the new icon
- Updates empty recycle bin action to use the new icon
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/package.json | Updates lucide-static dependency from 0.544.0 to 0.546.0 |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-trash-empty.ts | Adds new trash-empty icon SVG definition |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons.ts | Registers the new icon in the icon registry |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon-dictionary.json | Adds icon metadata to the dictionary |
| src/Umbraco.Web.UI.Client/src/packages/core/recycle-bin/entity-action/empty-recycle-bin/empty-recycle-bin.action.kind.ts | Updates empty recycle bin action to use new icon |
| src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts | Applies new icon to document delete action |
| src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/manifests.ts | Applies new icon to media delete action |
| src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-company.ts | Updates company icon SVG (unrelated icon update from lucide-static upgrade) |
Files not reviewed (1)
- src/Umbraco.Web.UI.Client/package-lock.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new icon and used it for deleting things in the trash bin