Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate to pnpm #5978

Open
wants to merge 30 commits into
base: next
Choose a base branch
from
Open

build: migrate to pnpm #5978

wants to merge 30 commits into from

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Jan 2, 2025

Changes Overview

This PR, migrates us to use pnpm for installs, revamps our pipelines to actually hit caches, updates our packages to export CJS types correctly, and a number of small cross-cutting changes.

I've also implemented prettier formatting into the repo merging in this PR: #5796

AI summary

This pull request includes significant updates to the build and publish workflows, the transition from npm to pnpm, and various dependency updates. The most important changes are as follows:

Workflow Improvements:

  • Added PNPM_VERSION environment variable and updated workflows to use pnpm for installing dependencies and running scripts. (.github/workflows/build.yml, .github/workflows/publish.yml) [1] [2]
  • Modified caching strategies to use pnpm and turbo cache for improved build performance. (.github/workflows/build.yml, .github/workflows/publish.yml) [1] [2] [3] [4]

Dependency and Script Updates:

  • Updated various dependencies and scripts to ensure compatibility with pnpm, including updates to package.json files and the addition of new dependencies. (demos/package.json, package.json, packages/core/package.json, packages/extension-blockquote/package.json, packages/extension-bold/package.json, packages/extension-bubble-menu/package.json) [1] [2] [3] [4] [5] [6]

Configuration Changes:

  • Added link-workspace-packages and prefer-workspace-packages settings to .npmrc for better workspace management. (.npmrc)
  • Updated lint-staged configuration and moved it from .lintstagedrc.js to package.json. (.lintstagedrc.js, package.json) [1] [2]

Codebase Enhancements:

  • Added linting scripts to individual package package.json files to ensure code quality. (packages/core/package.json, packages/extension-blockquote/package.json, packages/extension-bold/package.json, packages/extension-bubble-menu/package.json) [1] [2] [3] [4]
  • Improved type definitions in the exports field for better module resolution. (packages/core/package.json, packages/extension-blockquote/package.json, packages/extension-bold/package.json, packages/extension-bubble-menu/package.json) [1] [2] [3] [4]

Miscellaneous:

  • Removed unnecessary imports and updated paths in demos/vite.config.ts. (demos/vite.config.ts)
  • Updated the findParentNode function to improve type safety in packages/core/src/helpers/findParentNode.ts. (packages/core/src/helpers/findParentNode.ts)

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 6dacc65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 55 packages
Name Type
@tiptap/core Patch
@tiptap/extension-font-size Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bold Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-italic Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 6dacc65
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6777a5d09e555400088a6969
😎 Deploy Preview https://deploy-preview-5978--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 2, 2025

Open in Stackblitz

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@5978

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@5978

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@5978

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@5978

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@5978

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@5978

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@5978

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@5978

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@5978

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@5978

@tiptap/extension-collaboration-cursor

npm i https://pkg.pr.new/@tiptap/extension-collaboration-cursor@5978

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@5978

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@5978

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@5978

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@5978

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@5978

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@5978

@tiptap/extension-font-size

npm i https://pkg.pr.new/@tiptap/extension-font-size@5978

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@5978

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@5978

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@5978

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@5978

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@5978

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@5978

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@5978

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@5978

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@5978

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@5978

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@5978

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@5978

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@5978

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@5978

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@5978

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@5978

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@5978

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@5978

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@5978

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@5978

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@5978

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@5978

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@5978

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@5978

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@5978

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@5978

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@5978

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@5978

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@5978

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@5978

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@5978

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@5978

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@5978

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@5978

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@5978

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@5978

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@5978

commit: 2d0cacd

@nperez0111 nperez0111 mentioned this pull request Jan 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant