Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from npm to bun for faster dependency resolving #5473

Closed
wants to merge 3 commits into from
Closed

Conversation

bdbch
Copy link
Member

@bdbch bdbch commented Aug 12, 2024

Changes Overview

This PR moves away from npm in favor for bun to speed up package resolvement & caching.

Implementation Approach

I replaced the package-lock with a new bun.lockb and updated all scripts & Github actions accordingly

Testing Done

I ran builds, the dev setup & linting locally.

Additional Notes

This is not super crucial and needs a bit of testing because of the Github Actions changes.

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

@bdbch bdbch requested a review from nperez0111 August 12, 2024 22:04
@bdbch bdbch self-assigned this Aug 12, 2024
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 564c0e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for tiptap-embed failed. Why did it fail? →

Name Link
🔨 Latest commit 564c0e2
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66ba8747abe9630008fa1317

@nperez0111
Copy link
Contributor

nperez0111 commented Aug 14, 2024

Love bun, but I have to be honest that it isn't quite there yet in terms of NPM compatibility, you still will need to use NPM for publishing for example.

Could we maybe stick with pnpm instead, it is 90% the speed of bun, but is a much more mature project, allowing things like overrides & patching packages which is very useful

@bdbch
Copy link
Member Author

bdbch commented Aug 22, 2024

I don't mind pnpm - will update this PR accordingly then

@nperez0111
Copy link
Contributor

I think this will be superceded by #5978

@nperez0111 nperez0111 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Triage open
Development

Successfully merging this pull request may close these issues.

2 participants