Skip to content

Allow multiple processes to safely call delete() at the same time #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsroten merged 2 commits into from
Nov 19, 2024
Merged

Allow multiple processes to safely call delete() at the same time #43

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319be54
Allow rmtree to ignore FileNotFoundErrors during rmtree
jacob-indigo Nov 18, 2024
edc2401
Fix formatting
jacob-indigo Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/fcache/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,13 @@ def delete(self):
"""Delete the write buffer and cache directory."""
if not self._sync:
del self._buffer
shutil.rmtree(self.cache_dir)

# Allow multiple processes to delete() at the same time, meaning some or all of cache_dir may already be deleted
def _on_error(function, path, excinfo):
if excinfo[0] != FileNotFoundError:
raise

shutil.rmtree(self.cache_dir, onerror=_on_error)

def close(self):
"""Sync the write buffer, then close the cache.
Expand Down
Loading