Allow multiple processes to safely call delete() at the same time
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsroten
requested changes
Nov 19, 2024
Owner
tsroten
left a comment
tsroten
left a comment
There was a problem hiding this comment.
@jacob-indigo Thanks for this fix! It looks like the linter is complaining about the line length for line 158. If you can fix that, then I'll merge this in.
Contributor
Author
|
@tsroten Thanks! Should be good now |
tsroten
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #42
This PR allows
rmtree()to keep moving if it encounters aFileNotFoundErrorbut to still fail if it runs into any other type of error (e.g.PermissionError)