Preserve slash-separated EasyEDA pin aliases - #501
Open
rushabhcodes wants to merge 3 commits into
Open
Conversation
rushabhcodes
force-pushed
the
fix/slash-separated-pin-aliases
branch
from
August 21, 2026 15:10
212b547 to
9161145
Compare
rushabhcodes
marked this pull request as ready for review
August 21, 2026 15:10
imrishabh18
reviewed
Aug 21, 2026
| const pinLabels = { | ||
| pin1: ["pin1"], | ||
| pin2: ["pin2"] | ||
| pin1: ["_POS2","_NEG2"], |
Contributor
There was a problem hiding this comment.
Not sure if pin labels starting with underscore will render, you might want to test it on tscircuit.com
Contributor
Author
There was a problem hiding this comment.
the real jlcpcb sch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/and.during schematic parsingpinLabelsaliasesValidation
BUN_UPDATE_SNAPSHOTS=1 bun test(179 passed; 7 inline snapshots then updated with-u)bun run buildpasses