fix: preserve schematic pin numbers for named footprint pads - #533
Closed
GokulPandi-M wants to merge 2 commits into
Closed
fix: preserve schematic pin numbers for named footprint pads#533GokulPandi-M wants to merge 2 commits into
GokulPandi-M wants to merge 2 commits into
Conversation
GokulPandi-M
marked this pull request as ready for review
September 1, 2026 18:50
GokulPandi-M
force-pushed
the
codex/fix-c393941-card-detect-pin-mapping
branch
from
September 1, 2026 19:28
3d9add4 to
7790583
Compare
Contributor
|
we have a policy now of only fixing issues found on real circuits, I believe I already told you not sure |
Contributor
Author
|
@ShiboSoftwareDev Sorry, I should have mentioned the context earlier. I found this issue while checking the component for a hub board I’m building. I’ll include that context in future PRs so that you may get to know!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some EasyEDA parts use a functional name for a footprint pad but a numeric pin for the same schematic terminal. For C393941, the symbol defines card detect as pin 9 / CD while the footprint names the pad CD. The converter created a new pin 14, so users connecting pin 9 would not reach the physical card-detect pad.
Changes
Scope
The missing CD/DAT3 display name on pin 2 is a separate slash-label parsing issue covered by #501 and is intentionally not mixed into this fix. Pins 10-13 have only numeric names in the source data.
Verification
Follow-up fix for #530.