Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding GaussSBP blending coefficients #1299

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented Dec 15, 2022

Overwrites #1298, which had some issues with spurious commits in the commit history.

This will improve robustness of GaussSBP solvers by modifying the entropy projection when it yields negative densities and pressures for the compressible Euler equations.

@jlchan jlchan marked this pull request as draft December 15, 2022 14:02
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1299 (de5f642) into main (fa04120) will decrease coverage by 10.66%.
The diff coverage is 0.00%.

❗ Current head de5f642 differs from pull request most recent head 9398b66. Consider uploading reports for the commit 9398b66 to get more accurate results

@@             Coverage Diff             @@
##             main    #1299       +/-   ##
===========================================
- Coverage   92.94%   82.29%   -10.66%     
===========================================
  Files         359      357        -2     
  Lines       29779    29576      -203     
===========================================
- Hits        27677    24337     -3340     
- Misses       2102     5239     +3137     
Flag Coverage Δ
unittests 82.29% <0.00%> (-10.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Trixi.jl 71.43% <ø> (+3.25%) ⬆️
src/solvers/dgmulti/flux_differencing_gauss_sbp.jl 0.00% <0.00%> (-93.23%) ⬇️

... and 93 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants