Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GaussSBP shock capturing on curved meshes #1478

Merged
merged 62 commits into from
May 17, 2023

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented May 16, 2023

Adds support for curved meshes.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1478 (921e4ae) into main (fa04120) will increase coverage by 2.75%.
The diff coverage is 91.43%.

❗ Current head 921e4ae differs from pull request most recent head 7b3dcce. Consider uploading reports for the commit 7b3dcce to get more accurate results

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   92.94%   95.69%   +2.75%     
==========================================
  Files         359      360       +1     
  Lines       29779    29812      +33     
==========================================
+ Hits        27677    28527     +850     
+ Misses       2102     1285     -817     
Flag Coverage Δ
unittests 95.69% <91.43%> (+2.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/solvers/dgmulti/shock_capturing.jl 90.36% <90.32%> (-0.15%) ⬇️
...s/dgmulti_2d/elixir_euler_shockcapturing_curved.jl 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlchan jlchan requested a review from ranocha May 17, 2023 04:52
@ranocha ranocha enabled auto-merge (squash) May 17, 2023 05:06
@ranocha ranocha disabled auto-merge May 17, 2023 06:54
@ranocha ranocha merged commit ecec28d into trixi-framework:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants