-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance slice operation to support more range variation #1989
Conversation
@johnhuichen, please review this PR if you have a chance since you worked in this area previosly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just gotta fix the CI errors on the doc tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
- Coverage 85.50% 85.36% -0.14%
==========================================
Files 811 820 +9
Lines 100449 101175 +726
==========================================
+ Hits 85887 86372 +485
- Misses 14562 14803 +241 ☔ View full report in Codecov by Sentry. |
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1915, #1981, #1982, #1983
Changes
Primarily to support ONNX slice operation and closer PyTorch compatibility.
Testing
More unit tests