Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slice documentation #2024

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

antimora
Copy link
Collaborator

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#1989

Changes

Clarified behavior for D2 < D for slice ranges.

Testing

None

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (2a5d175) to head (48277ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2024   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files         845      845           
  Lines      105444   105444           
=======================================
  Hits        88843    88843           
  Misses      16601    16601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes that makes sense 😄 LGTM

@antimora antimora merged commit ed8a91d into tracel-ai:main Jul 16, 2024
14 checks passed
@antimora antimora deleted the update-slice-d branch July 16, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants