-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
docs: add preference migration guide #10326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also include a section talking about writing unit tests for the Migration, and set it as a requirement instead of just mentioning it as a Best practice.
db8583d to
09e2e82
Compare
rafaeltonholo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
09e2e82 to
930dd64
Compare
|
Sorry updated again, forgot to push the test section. |
rafaeltonholo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adding the suggestions!
Resolves #10325