Skip to content

refactor: migrate account setting key with migration logic #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wmontwe merged 5 commits into from
Jan 8, 2026
Merged

refactor: migrate account setting key with migration logic #10254

wmontwe merged 5 commits into from
Jan 8, 2026
+71 −6

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Dec 11, 2025 •
edited
Loading

Description

This PR migrates an existing account setting preference key to a new name and ensures a smooth transition for existing users by adding migration logic. This prevents loss of user preferences when the key name changes.

Changes

  • Preference Key Rename
    • Old key: "account_setup_auto_expand_folder"
    • New key: "auto_select_folder"
  • Migration Implementation
    • Added the migration in StorageMigrationTo29 to automatically migrate values from the old key to the new key for existing users.
  • Test
    • Added unit test to verify the migration logic works correctly.

@shamim-emon shamim-emon requested a review from a team as a code owner December 11, 2025 22:50
@shamim-emon shamim-emon changed the title Account Setting Key Migration Migrate Account Setting Key with Migration Logic Dec 11, 2025
@wmontwe wmontwe requested review from wmontwe and removed request for rafaeltonholo December 17, 2025 16:47
@wmontwe wmontwe assigned wmontwe and unassigned rafaeltonholo Dec 17, 2025
@wmontwe wmontwe changed the title Migrate Account Setting Key with Migration Logic refactor: migrate account setting key with migration logic Dec 17, 2025
@wmontwe wmontwe mentioned this pull request Jan 7, 2026
Closed
wmontwe
wmontwe requested changes Jan 7, 2026
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a migration mechanism for the app preferences. It could be found in the :legacy:storage module. I added a documentation on how to do this: #10326

@shamim-emon
feat: add migration to rename preference key from account_setup_auto_…
465159c 
…expand_folder to auto_select_folder
@shamim-emon
test: verify preference key migration from account_setup_auto_expand_…
b5d1cf9 
…folder to auto_select_folder in StorageMigrationTo29Test
@shamim-emon shamim-emon requested a review from wmontwe January 7, 2026 20:03
@shamim-emon shamim-emon changed the title refactor: migrate account setting key with migration logic Migrate account setting key with migration logic Jan 7, 2026
wmontwe
wmontwe approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wmontwe wmontwe changed the title Migrate account setting key with migration logic refactor: migrate account setting key with migration logic Jan 8, 2026
@wmontwe wmontwe merged commit 0a4911c into thunderbird:main Jan 8, 2026
13 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

None yet

Projects

None yet

Milestone

Thunderbird 17

Development

Successfully merging this pull request may close these issues.

Account Setting Key Migration

3 participants

@shamim-emon @wmontwe @rafaeltonholo