Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.12 compatibility #310

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix Python 3.12 compatibility #310

merged 1 commit into from
May 7, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented May 3, 2024

The distutils package is deprecated and no longer available in Python 3.12. We only used the strtobool function from distutils. This PR adds a strtobool replacement to iodata.utils and changes the imports from distutils by imports from our own utils.py.

I've also added .envrc to .gitignore because it is a local file I'm often using to manage different software envs.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@evohringer evohringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Thanks Toon for taking care.

@tovrstra
Copy link
Member Author

tovrstra commented May 7, 2024

Thanks for reviewing!

@tovrstra tovrstra merged commit 538d58d into theochem:master May 7, 2024
2 of 6 checks passed
@tovrstra tovrstra deleted the py3.12 branch May 7, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants