-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initiate switch to more modern GitHub Actions #312
Conversation
Some more background can be found in the discussion of pull request #263. |
Hi @tovrstra . I trust your judgement on this. As you note, the need to update our GitHub actions is essentially the conclusion from the long discussion in #263. As we agreed in February, we want to harmonize workflows so that all the QC-Devs packages have the same workflow; it is too hard to maintain if @tovrstra can you coordinate the rollout of these changes across repositories, updating the contributing guidelines (if required) and documenting the workflow? (I leave it to your judgement as to whether we should first make sure everything works for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me.
The merge-base changed after approval.
Thanks for the comments. I will open a new issue to maintain an overview of the pending and completed updates, of which this is the first one. |
This builds on the changes in #310, which will be merged before this one.
Main changes:
setup.py
bypyproject.toml
.github/workflows/ci.yaml
by.github/workflows/pytest.yaml
There are still related changes needed to get more linting back to work, but I'd like to defer this to later pull requests to limit the number of changes in one pull request. Things to be done include, probably one PR each:
ruff format
in the pre-commit config (and exclude some sections in the unit tests that would become poorly formatted) + lots of changes due to the automatic formatting.After this PR, the
master
branch will be renamed to themain
branch. After the planned PRs listed here, I will update the other PRs.