Skip to content

Add coverage for some implementation bugs in Iterator helper methods #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add coverage for some implementation bugs in Iterator helper methods #4496

wants to merge 3 commits into from

Conversation

anba
Copy link
Contributor

@anba anba commented May 19, 2025

  • SM fails the "suspended-start" tests.
  • V8 fails the "suspended-yield" tests.
  • JSC fails the "flatMap/return-method-called-with-zero-arguments.js" test.
  • JSC fails the "return-method-can-be-absent-for-underlying.js" test.

anba added 3 commits May 19, 2025 09:50
@anba
Add coverage when iterator close calls into iterator helper
e202fcb 
- V8 fails the "suspended-yield" tests.
- SM fails the "suspended-start" tests.
- JSC passes all tests.
@anba
Add coverage for correct number of arguments passed to iterator helpers
d291809 
JSC fails "flatMap/return-method-called-with-zero-arguments.js".
@anba
Add coverage when return method is absent in flatMap
76018c0 
JSC fails the "return-method-can-be-absent-for-underlying.js" test.
@anba anba requested a review from a team as a code owner May 19, 2025 08:22
@anba anba mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anba @Ms2ger