Deprecate "mongo" handler type in favor of new "mongodb" syntax #550
Conversation
jmikola
force-pushed
the
3.x-mongodb-handler-syntax
branch
from
dcfe73f to
a073d14
Compare
|
The Fabbot failure seems unrelated:
None of the new test methods introduced in this PR specify a return type. |
|
|
||
| if (empty($handler['formatter'])) { | ||
| $formatter = new Definition('Monolog\Formatter\MongoDBFormatter'); | ||
| $formatter->setPublic(false); |
There was a problem hiding this comment.
It's an inline service, it can't be public, you can remove this statement.
There was a problem hiding this comment.
I saw that Definition has private bool $public = false. I assume most of these setPublic(false) calls throughout MonologExtension are just obsolete.
We added the rule after. We should probably remove the return type in this branch. It's annoying to ignore fabbot failures. Edit: you can rebase. |
Define a new "mongodb" handler type. It accepts an "id" reference like the old "mongo" type; however, "uri" instead of a single "host" and "port". The "uri" option is more flexible.
Additionally, the "username" and "password" options have been renamed and are no longer used to modify the connection string directly ("mongo" never applied URL encoding). Instead, the options are set in the URI options array, which does not require encoding. The "mongodb" never requires a password, as a username alone is valid for some auth mechanisms.
Lastly, a "monolog-bundle" app name is specified when the bundle constructs a MongoDB\Client instance for both "mongo" and "mongodb" handler syntax.
jmikola
force-pushed
the
3.x-mongodb-handler-syntax
branch
from
a271f81 to
899c151
Compare
|
|
||
| $client = new Definition('MongoDB\Client', [ | ||
| $handler['mongodb']['uri'], | ||
| $uriOptions, |
There was a problem hiding this comment.
Should we have writeConcern: 0 or 1 by default for logs?
You can accept driver options.
There was a problem hiding this comment.
That can be specified in the uri option. I only wanted to break out username and password since (a) they might come from separate env vars and (b) they were supported in the original mongo syntax and I wanted to avoid dealing with URI encoding.
We can revisit when adding more options across the board.
You can accept driver options
Were you actually referring to $driverOptions (i.e. third ctor param) or just URI options?
|
For the error in the CI, we can add |
2 participants
Define a new "mongodb" handler type. It accepts an "id" reference like the old "mongo" type; however, "uri" instead of a single "host" and "port". The "uri" option is more flexible.
Additionally, the "username" and "password" options have been renamed and are no longer used to modify the connection string directly ("mongo" never applied URL encoding). Instead, the options are set in the URI options array, which does not require encoding. The "mongodb" never requires a password, as a username alone is valid for some auth mechanisms.
Lastly, a "monolog-bundle" app name is specified when the bundle constructs a MongoDB\Client instance for both "mongo" and "mongodb" handler syntax.