Replace deprecated code in MongoDB classes and allow 2.0+ #1998
+23
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monolog already required mongodb/mongodb 1.8+ (and a related ext-mongodb version) so this code path was never used.
The original selectCollection method is deprecated. Since Monolog itself requires PHP 8.1, it should be sane to rely on 1.21+, which shares the same requirement.
GromNaN
reviewed
Oct 15, 2025
GromNaN
reviewed
Oct 15, 2025
GromNaN
reviewed
Oct 16, 2025
GromNaN
approved these changes
Oct 17, 2025
|
@GromNaN: all of the CI failures here seem unrelated. Can you confirm? |
GromNaN
reviewed
Oct 23, 2025
|
Well, merging, thanks! |
|
That was quick. Yup, @GromNaN reviewed earlier and I just followed up to address his feedback. symfony/monolog-bundle#550 is next, but I think he can take care of merging that. |
Seldaek
pushed a commit
that referenced
this pull request
Oct 23, 2025
* Remove unused code path in MongoDBFormatter Monolog already required mongodb/mongodb 1.8+ (and a related ext-mongodb version) so this code path was never used. * Use Collection::getCollection() from mongodb/mongodb 1.21 The original selectCollection method is deprecated. Since Monolog itself requires PHP 8.1, it should be sane to rely on 1.21+, which shares the same requirement. * Update class refs for MongoDB extension and library * Conditionally use Collection getter by version * Relax PHPLIB version requirement * Use RequiresPhpExtension attribute to require ext-mongodb * Import UTCDateTime class and revise var names
|
Backported in 2.x here 2dc620c too |
I almost hit merge but as I reviewed you force pushed.. that was close :D |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPORM-398
This removes some deprecated code related to the MongoDB extension and library. Since Monolog requires PHP 8.1, I'm assuming it's kosher to also rely on mongodb/mongodb 1.21+ (same platform requirement).