[make:test] Remove trailing slash in assertResponseRedirects tests #1773
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Jan 11, 2026
Member
|
Thank you @tcoch. |
GromNaN
added a commit
that referenced
this pull request
Jan 13, 2026
…MakerBundle's CI (GromNaN) This PR was merged into the 1.x branch. Discussion ---------- [make:crud] Ensure the generated functional tests run in MakerBundle's CI In order to ensure there is no regression in the generated test case (#1773), they must be run in MakerBundle's CI. The `markTestIncomplete` call stops the execution by throwing and exception. Skipping all the test body. By moving this call at the end of the method, the tests are fully run. I even wonder if marking tests as incomplete serves any purpose. For reference, this was added in #307, this point was not discussed. Commits ------- 69e911a [make:crud] Move markTestIncomplete at the end to ensure the test is run in MakerBundle CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the box, the generated tests do not work.
I found out that removing the trailing slash is actually enough to make them work !
This PR aims to fix that.