Commit 4994519
committed
minor #1774 [make:crud] Ensure the generated functional tests run in MakerBundle's CI (GromNaN)
This PR was merged into the 1.x branch.
Discussion
----------
[make:crud] Ensure the generated functional tests run in MakerBundle's CI
In order to ensure there is no regression in the generated test case (#1773), they must be run in MakerBundle's CI.
The `markTestIncomplete` call stops the execution by throwing and exception. Skipping all the test body. By moving this call at the end of the method, the tests are fully run.
I even wonder if marking tests as incomplete serves any purpose.
For reference, this was added in #307, this point was not discussed.
Commits
-------
69e911a [make:crud] Move markTestIncomplete at the end to ensure the test is run in MakerBundle CI1 file changed
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | 43 | | |
45 | 44 | | |
46 | 45 | | |
| |||
54 | 53 | | |
55 | 54 | | |
56 | 55 | | |
| 56 | + | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | | - | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
108 | | - | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
| |||
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| 123 | + | |
| 124 | + | |
122 | 125 | | |
123 | 126 | | |
0 commit comments