[McpBundle] Compiler pass for tools #168
Open
+111
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
TomHart
force-pushed
the
compiler_pass_for_tools
branch
from
c61b564 to
58536bd
Compare
OskarStark
reviewed
Jul 20, 2025
TomHart
force-pushed
the
compiler_pass_for_tools
branch
2 times, most recently
from
da439c8 to
b1c22fe
Compare
chr-hertel
added
the
MCP Bundle
chr-hertel
reviewed
Jul 21, 2025
src/mcp-bundle/src/DependencyInjection/ContainerBuilder/MCPToolChainCompilerPass.php
Outdated
Show resolved
Hide resolved
chr-hertel
reviewed
Jul 21, 2025
src/mcp-bundle/src/DependencyInjection/ContainerBuilder/MCPToolChainCompilerPass.php
Outdated
Show resolved
Hide resolved
chr-hertel
reviewed
Jul 21, 2025
src/mcp-bundle/src/DependencyInjection/ContainerBuilder/MCPToolChainCompilerPass.php
Outdated
Show resolved
Hide resolved
chr-hertel
reviewed
Jul 21, 2025
chr-hertel
reviewed
Jul 21, 2025
TomHart
force-pushed
the
compiler_pass_for_tools
branch
2 times, most recently
from
cd6c9f1 to
220575f
Compare
|
You're welcome @chr-hertel. I believe I've address everything you mentioned if you'd like to take another look whenever you have time. |
OskarStark
reviewed
Jul 21, 2025
|
Could be a follow up PR, but I would like to have an attribute for this like in the agent |
chr-hertel
reviewed
Jul 22, 2025
src/mcp-bundle/src/DependencyInjection/ContainerBuilder/McpToolChainCompilerPass.php
Outdated
Show resolved
Hide resolved
Address comments lint Update src/mcp-bundle/CHANGELOG.md Co-authored-by: Oskar Stark <[email protected]> Update src/mcp-bundle/CHANGELOG.md Co-authored-by: Oskar Stark <[email protected]> Update src/mcp-bundle/doc/index.rst Co-authored-by: Oskar Stark <[email protected]> Update src/mcp-bundle/doc/index.rst Co-authored-by: Oskar Stark <[email protected]> Remove strict types
TomHart
force-pushed
the
compiler_pass_for_tools
branch
from
3b01c9b to
20ef42c
Compare
|
@chr-hertel my bad on missing the strict types, updated now and rebased into 1 commit |
OskarStark
approved these changes
Jul 22, 2025
stof
reviewed
Jul 23, 2025
| @@ -63,6 +63,11 @@ Configuration | |||
| sse: | |||
| url: 'http://localhost:8000/sse' # URL to SSE endpoint of MCP server | |||
| To add your tools to the MCP server, add the following tag:: | |||
|
|
|||
| #[AutoconfigureTag('mcp.tool')] | |||
There was a problem hiding this comment.
this is not the right recommendation IMO:
AutoconfigureTag(like allAutoconfigure*attributes) is about defining an autoconfiguration rule applying on all child types (its original intent is to be used on interfaces). Recommending to use it to apply a tag on a service directly is a bad idea, as it can have unintended side effects for non-final classes (as it will also impact autoconfigured services defined with child classes)- if the goal is to automatically tag autoconfigured services implementing ToolExecutorInterface with the
mcp.toolto make it simpler for projects adding a custom tool, the solution is for the MCP bundle to register an autoconfiguration rule for ToolExecutorInterface, so that projects only need to implement the interface and be done with it.
| return; | ||
| } | ||
|
|
||
| $definition = new Definition(ToolChain::class); |
There was a problem hiding this comment.
you could always define a mcp.tool_chain service using a tagged iterator, and then defining a ToolExecutorInterface alias pointing at it (which projects can still override if they don't want to rely on the tool chain).
There is no need for this compiler pass IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Compiler Pass to find tools and register them in the ToolChain