-
-
Notifications
You must be signed in to change notification settings - Fork 38
[McpBundle] Wire & configure services explicitly #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+54
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
883efeb
to
52a1803
Compare
Covers McpBundle part of #77 too |
52a1803
to
f0a63bd
Compare
valtzu
commented
Jul 21, 2025
stof
reviewed
Jul 23, 2025
ed42cb5
to
447b412
Compare
chr-hertel
requested changes
Jul 24, 2025
Comment on lines
+43
to
+47
->set('mcp.server.request_handler.tool_list', ToolListHandler::class) | ||
->args([ | ||
service('mcp.tool_collection'), | ||
20, | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found out while testing that this is missing the tag:
Suggested change
->set('mcp.server.request_handler.tool_list', ToolListHandler::class) | |
->args([ | |
service('mcp.tool_collection'), | |
20, | |
]) | |
->set('mcp.server.request_handler.tool_list', ToolListHandler::class) | |
->args([ | |
service('mcp.tool_collection'), | |
20, | |
]) | |
->tag('mcp.server.request_handler') |
447b412
to
d6cb1e2
Compare
chr-hertel
approved these changes
Jul 25, 2025
Thank you @valtzu. |
OskarStark
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't autowire / autoconfigure any services in mcp bundle