-
Notifications
You must be signed in to change notification settings - Fork 19
feat(styles): add icon and text support for segmented button #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hugomslv
wants to merge
21
commits into
main
Choose a base branch
from
5154-segmented-button-enhancement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0ebffe9
feat(segmented-button): add icon and text support
hugomslv 65d214b
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 5097b34
chore(segmented-button): apply changes requested in PR review
hugomslv 448ac1e
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 98a8862
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv bcb6990
Merge branch '5154-segmented-button-enhancement' of https://github.coβ¦
hugomslv 30f316c
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 593b841
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv b7c5032
fix PR comments
hugomslv 7b17665
Merge branch '5154-segmented-button-enhancement' of https://github.coβ¦
hugomslv 502991d
Update from main and modify pnpm-lock.yaml
hugomslv 982efac
Delete _post-icon-version.scss
hugomslv dafe1fe
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 9f5234c
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv f7b132b
fix comments
hugomslv aabe4bf
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 8061270
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 81ef193
Update .changeset/stale-days-smoke.md
hugomslv ddfdeea
Update packages/documentation/src/stories/components/segmented-buttonβ¦
hugomslv 8967ac3
Merge branch 'main' into 5154-segmented-button-enhancement
hugomslv 8b40d61
fix comments
hugomslv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@swisspost/design-system-documentation': minor | ||
'@swisspost/design-system-styles': minor | ||
--- | ||
|
||
Enabled having icons in the segmented button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the gap token is incorrect. Can you please check with @sandra-post?