-
Notifications
You must be signed in to change notification settings - Fork 27
feat(styles): add icon and text support for segmented button #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0ebffe9
65d214b
5097b34
448ac1e
98a8862
bcb6990
30f316c
593b841
b7c5032
7b17665
502991d
982efac
dafe1fe
9f5234c
f7b132b
aabe4bf
8061270
81ef193
ddfdeea
8967ac3
8b40d61
ef1743a
684e81b
fc35937
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@swisspost/design-system-documentation': patch | ||
| '@swisspost/design-system-styles': minor | ||
| --- | ||
|
|
||
| Enabled having icons in the segmented button. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,6 +30,7 @@ $post-segmented-button-max-count: 8; | |||||
| label { | ||||||
| flex: 0 1 100%; | ||||||
| display: flex; | ||||||
| gap: tokens.get('button-segmented-gap-inline'); | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the gap token is incorrect. Can you please check with @sandra-post?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The gap is still incorrect, I checked the Figma design and this token should used instead:
Suggested change
|
||||||
| justify-content: center; | ||||||
| align-items: center; | ||||||
| position: relative; | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.