feat(segmented-button): add icon and text support #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
🦋 Changeset detectedLatest commit: 65d214b The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alizedebray
requested changes
May 21, 2025
There was a problem hiding this comment.
You did not add or remove libraries, there shouldn't be any changes to the lock file.
There was a problem hiding this comment.
Is this change necessary?
| @@ -1,6 +1,6 @@ | |||
| import type { StoryObj } from '@storybook/web-components'; | |||
| import meta from './segmented-button.stories'; | |||
| import { html } from 'lit'; | |||
| import { html, nothing } from 'lit'; // ← ajout de `nothing` | |||
There was a problem hiding this comment.
Suggested change
| import { html, nothing } from 'lit'; // ← ajout de `nothing` | |
| import { html, nothing } from 'lit'; |
| '@swisspost/design-system-components': minor | ||
| --- | ||
|
|
||
| added a version with an icon to the segmented button. |
There was a problem hiding this comment.
Suggested change
| added a version with an icon to the segmented button. | |
| Added a version with an icon to the segmented button. |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@swisspost/design-system-components': minor | |||
There was a problem hiding this comment.
You also changed the styles package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
Please include a summary of the changes made in this PR.
🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
📝 Checklist