Skip to content

Avoid unsafeBitCast() in the new interop target. #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2025
Merged

Avoid unsafeBitCast() in the new interop target. #1384

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
90f814a
Avoid `unsafeBitCast()` in the new interop target.
grynspan Oct 28, 2025
42b1dee
Fix typo
grynspan Oct 28, 2025
303f3e6
Fix another typo
grynspan Oct 28, 2025
d075271
Support Embedded Swift and add a package target for building purposes…
grynspan Oct 29, 2025
083957c
Need a product too
grynspan Oct 29, 2025
d637dc5
Missing exclude
grynspan Oct 29, 2025
34fb4f5
Add a comment explaining why the non-atomic load is safe
grynspan Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions Sources/_TestingInterop/FallbackEventHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ private nonisolated(unsafe) let _fallbackEventHandler = {
}()
#else
/// The installed event handler.
private nonisolated(unsafe) let _fallbackEventHandler = Atomic<UnsafeRawPointer?>(nil)
private nonisolated(unsafe) let _fallbackEventHandler = Atomic<Unmanaged<AnyObject>?>(nil)
#endif

/// A type describing a fallback event handler that testing API can invoke as an
Expand Down Expand Up @@ -68,7 +68,7 @@ package func _swift_testing_getFallbackEventHandler() -> FallbackEventHandler? {
}
#else
return _fallbackEventHandler.load(ordering: .sequentiallyConsistent).flatMap { fallbackEventHandler in
unsafeBitCast(fallbackEventHandler, to: FallbackEventHandler?.self)
fallbackEventHandler.takeUnretainedValue() as? FallbackEventHandler
}
#endif
}
Expand All @@ -86,8 +86,10 @@ package func _swift_testing_getFallbackEventHandler() -> FallbackEventHandler? {
@_cdecl("_swift_testing_installFallbackEventHandler")
@usableFromInline
package func _swift_testing_installFallbackEventHandler(_ handler: FallbackEventHandler) -> CBool {
var result = false

#if SWT_TARGET_OS_APPLE && !SWT_NO_OS_UNFAIR_LOCK
return _fallbackEventHandler.withUnsafeMutablePointers { fallbackEventHandler, lock in
result = _fallbackEventHandler.withUnsafeMutablePointers { fallbackEventHandler, lock in
os_unfair_lock_lock(lock)
defer {
os_unfair_lock_unlock(lock)
Expand All @@ -99,8 +101,15 @@ package func _swift_testing_installFallbackEventHandler(_ handler: FallbackEvent
return true
}
#else
let handler = unsafeBitCast(handler, to: UnsafeRawPointer.self)
return _fallbackEventHandler.compareExchange(expected: nil, desired: handler, ordering: .sequentiallyConsistent).exchanged
let handler = Unmanaged.passRetained(handler as AnyObject)
defer {
if !result {
handler.release()
}
}

result = _fallbackEventHandler.compareExchange(expected: nil, desired: handler, ordering: .sequentiallyConsistent).exchanged
#endif
return result
}
#endif